Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Custom app ID #1915

Merged
merged 4 commits into from
Oct 25, 2024
Merged

Add Custom app ID #1915

merged 4 commits into from
Oct 25, 2024

Conversation

InfiniteCoder06
Copy link
Contributor

@InfiniteCoder06 InfiniteCoder06 commented Oct 20, 2024

Add Custom App ID generally used for Track Only Sources like ApkMirror
Without App ID
With Custom App ID

@ImranR98
Copy link
Owner

Not sure it's a good idea to let users change App IDs. They are meant to be unique and unchanging, and a lot of features have been written with this in mind (even app entry/config data is stored in a JSON file named after the app ID). Have you tested this thoroughly to make sure it doesn't break anything?

@InfiniteCoder06
Copy link
Contributor Author

InfiniteCoder06 commented Oct 20, 2024

Not sure it's a good idea to let users change App IDs. They are meant to be unique and unchanging, and a lot of features have been written with this in mind (even app entry/config data is stored in a JSON file named after the app ID). Have you tested this thoroughly to make sure it doesn't break anything?

The thing is that if we keep track only the app ID is a temporary one, which means even if the local app is installed it shows as if it is a pseudo version which makes it difficult to compare with the local installed version hence for that this is implemented, I will make it unchangeable once assigned

@ImranR98
Copy link
Owner

Still not sure about this. Will need to test it more.

@InfiniteCoder06
Copy link
Contributor Author

Added Validation of App ID (Package Name) as well

Still not sure about this. Will need to test it more.

@ImranR98
Copy link
Owner

It shouldn't be possible to use this when an app is not added as track-only (should be hidden). Also could you describe what ways you have tested this

@ImranR98 ImranR98 merged commit e3fcf6e into ImranR98:main Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants